yiguolei commented on code in PR #10821:
URL: https://github.com/apache/doris/pull/10821#discussion_r920710172
##########
be/src/vec/exec/vaggregation_node.cpp:
##########
@@ -1048,16 +1094,38 @@ Status
AggregationNode::_merge_with_serialized_key(Block* block) {
std::visit(
[&](auto&& agg_method) -> void {
using HashMethodType = std::decay_t<decltype(agg_method)>;
+ using HashTableType = std::decay_t<decltype(agg_method.data)>;
using AggState = typename HashMethodType::State;
AggState state(key_columns, _probe_key_sz, nullptr);
_pre_serialize_key_if_need(state, agg_method, key_columns,
rows);
+ std::vector<size_t> hash_values;
Review Comment:
any difference between vector and dynamic array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
