Copilot commented on code in PR #49084:
URL: https://github.com/apache/doris/pull/49084#discussion_r2010202889
##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -1694,6 +1694,12 @@
[['repeat'], 'STRING', ['STRING', 'INT'], 'ALWAYS_NULLABLE'],
[['lpad'], 'STRING', ['STRING', 'INT', 'STRING'], 'ALWAYS_NULLABLE'],
[['rpad'], 'STRING', ['STRING', 'INT', 'STRING'], 'ALWAYS_NULLABLE'],
+ [['format_round'], 'STRING', ['BIGINT'], ''],
Review Comment:
The signature for format_round with 'BIGINT' is missing the second parameter
of type INT; this function requires two arguments as reflected in the
FormatRound constructor.
```suggestion
[['format_round'], 'STRING', ['BIGINT', 'INT'], ''],
```
##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -1694,6 +1694,12 @@
[['repeat'], 'STRING', ['STRING', 'INT'], 'ALWAYS_NULLABLE'],
[['lpad'], 'STRING', ['STRING', 'INT', 'STRING'], 'ALWAYS_NULLABLE'],
[['rpad'], 'STRING', ['STRING', 'INT', 'STRING'], 'ALWAYS_NULLABLE'],
+ [['format_round'], 'STRING', ['BIGINT'], ''],
+ [['format_round'], 'STRING', ['LARGEINT'], ''],
Review Comment:
The signature for format_round with 'LARGEINT' is missing the second
parameter of type INT; please update it to include the INT parameter for
consistency with the FormatRound implementation.
```suggestion
[['format_round'], 'STRING', ['LARGEINT', 'INT'], ''],
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
