HappenLee commented on code in PR #10296:
URL: https://github.com/apache/doris/pull/10296#discussion_r918867005
##########
be/src/vec/aggregate_functions/aggregate_function_java_udaf.h:
##########
@@ -96,6 +98,7 @@ struct AggregateJavaUdafData {
ctor_params.__set_input_buffer_ptrs((int64_t)input_values_buffer_ptr.get());
ctor_params.__set_input_nulls_ptrs((int64_t)input_nulls_buffer_ptr.get());
ctor_params.__set_output_buffer_ptr((int64_t)output_value_buffer.get());
+
ctor_params.__set_input_places_ptr((int64_t)input_place_ptrs.get());
Review Comment:
the strunct is too big, rethink the logic and try to opt the struct. because
of after the pr, the struct should be simple
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
