gavinchou commented on code in PR #48759: URL: https://github.com/apache/doris/pull/48759#discussion_r2008785130
########## be/src/cloud/cloud_cumulative_compaction.h: ########## @@ -37,6 +37,9 @@ class CloudCumulativeCompaction : public CloudCompactionMixin { void do_lease(); + int64_t get_input_rowsets_total_size() const { return _input_rowsets_total_size; } Review Comment: naming `get_input_rowsets_bytes` size is ambiguous for count or bytes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org