yiguolei commented on code in PR #49281:
URL: https://github.com/apache/doris/pull/49281#discussion_r2008780201
##########
be/src/pipeline/pipeline_task.cpp:
##########
@@ -225,54 +230,32 @@ bool PipelineTask::_wait_to_start() {
// Before task starting, we should make sure
// 1. Execution dependency is ready (which is controlled by FE 2-phase
commit)
// 2. Runtime filter dependencies are ready
- _blocked_dep = _execution_dep->is_blocked_by(this);
- if (_blocked_dep != nullptr) {
- _blocked_dep->start_watcher();
- return true;
- }
+ ASSIGN_BLOCKING_STATUS(_execution_dep);
for (auto* op_dep : _filter_dependencies) {
- _blocked_dep = op_dep->is_blocked_by(this);
- if (_blocked_dep != nullptr) {
- _blocked_dep->start_watcher();
- return true;
- }
+ ASSIGN_BLOCKING_STATUS(op_dep);
Review Comment:
这个宏别存在了，代码没省多少，但是不利于代码阅读
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
