yiguolei commented on code in PR #49273: URL: https://github.com/apache/doris/pull/49273#discussion_r2005887280
########## be/src/pipeline/dependency.h: ########## @@ -156,7 +156,7 @@ class Dependency : public std::enable_shared_from_this<Dependency> { MonotonicStopWatch _watcher; std::mutex _task_lock; - std::vector<PipelineTask*> _blocked_task; + std::vector<std::shared_ptr<PipelineTask>> _blocked_task; Review Comment: 这里是share ptr 感觉会循环引用。 比如你看task ---》 pipeline context ---》state --》dependency ---》 task -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org