morrySnow commented on code in PR #49239:
URL: https://github.com/apache/doris/pull/49239#discussion_r2005349798
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromCommand.java:
##########
@@ -128,7 +128,14 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
LogicalPlanAdapter logicalPlanAdapter = new
LogicalPlanAdapter(logicalQuery, ctx.getStatementContext());
updateSessionVariableForDelete(ctx.getSessionVariable());
NereidsPlanner planner = new NereidsPlanner(ctx.getStatementContext());
- planner.plan(logicalPlanAdapter, ctx.getSessionVariable().toThrift());
+ try {
+ // delete not need select priv
+ ctx.setSkipAuth(true);
Review Comment:
`ctx.setSkipAuth(true)` should be outside of try
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DeleteFromCommand.java:
##########
@@ -128,7 +128,14 @@ public void run(ConnectContext ctx, StmtExecutor executor)
throws Exception {
LogicalPlanAdapter logicalPlanAdapter = new
LogicalPlanAdapter(logicalQuery, ctx.getStatementContext());
updateSessionVariableForDelete(ctx.getSessionVariable());
NereidsPlanner planner = new NereidsPlanner(ctx.getStatementContext());
- planner.plan(logicalPlanAdapter, ctx.getSessionVariable().toThrift());
+ try {
+ // delete not need select priv
+ ctx.setSkipAuth(true);
+ planner.plan(logicalPlanAdapter,
ctx.getSessionVariable().toThrift());
+ } finally {
+ ctx.setSkipAuth(false);
Review Comment:
should set to original value, not to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
