BiteTheDDDDt commented on PR #10775:
URL: https://github.com/apache/doris/pull/10775#issuecomment-1180603761
yes
------------------ Original ------------------
From: Xinyi Zou ***@***.***>
Date: Mon,Jul 11,2022 11:55 PM
To: apache/doris ***@***.***>
Cc: Pxl ***@***.***>, Author ***@***.***>
Subject: Re: [apache/doris] [Bug][Memtable] fix core dump on int128 because
not aligned by 16 byte (PR #10775)
@xinyiZzz commented on this pull request.
In be/src/runtime/mem_pool.h:
> @@ -104,9 +104,17 @@ class MemPool { /// of the current chunk.
Creates a new chunk if there aren't any chunks /// with enough capacity.
uint8_t* allocate(int64_t size, Status* rst = nullptr) {+ // TODO:
rethink if DEFAULT_ALIGNMENT should be 82, malloc is aligned by 16.
Do you mean DEFAULT_ALIGNMENT changed from 8 to 16
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
