zxealous commented on code in PR #10749: URL: https://github.com/apache/doris/pull/10749#discussion_r917576053
########## be/src/vec/functions/function_string.h: ########## @@ -540,6 +542,11 @@ class FunctionStringConcatWs : public IFunction { } else { null_list[i] = &const_null_map->get_data(); } + + if (is_array(remove_nullable(block.get_by_position(arguments[i]).type))) { Review Comment: done ########## docs/en/docs/sql-manual/sql-functions/string-functions/concat_ws.md: ########## @@ -28,10 +28,10 @@ under the License. ### Description #### Syntax -`VARCHAR concat ws (VARCHAR sep, VARCHAR str,...)` +`VARCHAR concat ws (VARCHAR sep, VARCHAR str,...) or VARCHAR concat_ws(VARCHAR sep, ARRAY array)` Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org