HappenLee commented on code in PR #49212: URL: https://github.com/apache/doris/pull/49212#discussion_r2001598067
########## be/src/vec/exprs/lambda_function/varray_map_function.cpp: ########## @@ -77,9 +77,8 @@ class ArrayMapFunction : public LambdaFunction { std::string get_name() const override { return name; } - doris::Status execute(VExprContext* context, doris::vectorized::Block* block, - int* result_column_id, const DataTypePtr& result_type, - const VExprSPtrs& children) override { + Status execute(VExprContext* context, vectorized::Block* block, int* result_column_id, + const DataTypePtr& result_type, const VExprSPtrs& children) override { LambdaArgs args; // collect used slot ref in lambda function body _collect_slot_ref_column_id(children[0], args); Review Comment: refactor all private func of ArrayMapFunction, only pass the use param, not args -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org