kaka11chen opened a new pull request, #49182:
URL: https://github.com/apache/doris/pull/49182
### What problem does this PR solve?
### Release note
Added Parquet decoder unit tests and fixed bugs identified through these
tests.
In addition to the unit tests, the main changes include:
- Modification of `Decoder::set_data()` Return Type from `void` to `Status`
to capture error in the unit tests.
Changed the return type of Decoder::set_data() from void to Status to enable
checking whether the operation succeeded in unit tests.
- Separation of Header and Implementation Files
Moved the definitions of non-template functions from header files (e.g.,
delta_bit_pack_decoder.h) to corresponding .cpp files (e.g.,
fix_length_plain_decoder.cpp).
Resolved link errors caused by duplicate symbols during the build process of
unit tests.
This change optimizes the code structure, improves compilation efficiency,
and avoids potential link conflicts.
- Bug Fixes
- Fixed the issue where `BoolRLEDecoder::skip_values()` was not
functioning correctly.
- Fixed the issues where
`FixLengthDictDecoder::read_dict_values_to_column() `and
`FixLengthDictDecoder::convert_dict_column_to_string_column()` were not
functioning correctly.
### Future Work:
Add more test cases for invalid scenarios in these unit tests.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [x] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
