JNSimba commented on code in PR #573:
URL: 
https://github.com/apache/doris-flink-connector/pull/573#discussion_r1998623214


##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/JsonDebeziumSchemaSerializer.java:
##########
@@ -130,7 +131,8 @@ public JsonDebeziumSchemaSerializer(
             String targetTablePrefix,
             String targetTableSuffix,
             SchemaChangeMode schemaChangeMode,
-            TableNameConverter tableNameConverter) {
+            TableNameConverter tableNameConverter,
+            boolean ignoreIncompatible) {

Review Comment:
   When we dynamically create a table, we don't need to perceive 
ignoreIncompatible in theory.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to