[GitHub] [doris] zhannngchen commented on a diff in pull request #10706: [feature-wip](unique-key-merge-on-write) add bloom filter index for primary key, DSIP-018[1.2]

[GitBox]

zhannngchen commented on code in PR #10706:
URL: https://github.com/apache/doris/pull/10706#discussion_r917232884


##########
be/src/olap/primary_key_index.cpp:
##########
@@ -30,12 +30,17 @@ Status PrimaryKeyIndexBuilder::init() {
     options.encoding = 
segment_v2::EncodingInfo::get_default_encoding(type_info, true);
     // TODO(liaoxin) test to confirm whether it needs to be compressed
     options.compression = segment_v2::NO_COMPRESSION; // currently not 
compressed
-    _index_builder.reset(new segment_v2::IndexedColumnWriter(options, 
type_info, _file_writer));
-    return _index_builder->init();
+    _primary_key_index_builder.reset(
+            new segment_v2::IndexedColumnWriter(options, type_info, 
_file_writer));
+    RETURN_IF_ERROR(_primary_key_index_builder->init());
+
+    return 
segment_v2::BloomFilterIndexWriter::create(segment_v2::BloomFilterOptions(), 
type_info,
+                                                      
&_bloom_filter_index_builder);
 }
 
 Status PrimaryKeyIndexBuilder::add_item(const Slice& key) {
-    _index_builder->add(&key);
+    _primary_key_index_builder->add(&key);

Review Comment:
   RETURN_IF_ERROR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org