morrySnow commented on code in PR #49087:
URL: https://github.com/apache/doris/pull/49087#discussion_r1995254007
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java:
##########
Review Comment:
also fix:
- split_by_string: `select split_by_string('a😁a😁a', '');`
- character_length: `select character_length('a😁a😁a');`
- replace_empty: `select replace_empty('a😁a😁a', '', '2');`
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/StringArithmetic.java:
##########
@@ -776,33 +781,15 @@ public static Expression strcmp(StringLikeLiteral first,
StringLikeLiteral secon
*/
@ExecFunction(name = "strleft")
Review Comment:
if strLeft is alias for left, we'd better remove strleft function from fe
and add left a alias `strleft` in
`fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
