LiBinfeng-01 commented on code in PR #49033:
URL: https://github.com/apache/doris/pull/49033#discussion_r1995025017
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/DateTimeExtractAndTransform.java:
##########
@@ -631,19 +636,19 @@ public static Expression strToDate(StringLikeLiteral str,
StringLikeLiteral form
boolean hasMicroPart = org.apache.doris.analysis.DateLiteral
.hasMicroSecondPart(format.getStringValue());
return
DateTimeV2Literal.fromJavaDateType(DateUtils.getTime(DateUtils.formatBuilder(format.getValue())
- .toFormatter(), str.getValue()), hasMicroPart ? 6 : 0);
+
.toFormatter().withResolverStyle(ResolverStyle.STRICT), str.getValue()),
hasMicroPart ? 6 : 0);
Review Comment:
toFormatter is one of DateTimeFormatterBuilder.java functions, which is not
easy to refactor. And we use it a lot, it may cause a wide range of affection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
