morningman commented on code in PR #48723:
URL: https://github.com/apache/doris/pull/48723#discussion_r1991713735
##########
be/src/vec/exec/format/table/paimon_reader.cpp:
##########
@@ -38,6 +38,134 @@ PaimonReader::PaimonReader(std::unique_ptr<GenericReader>
file_format_reader,
ADD_CHILD_TIMER(_profile, "DeleteFileReadTime", paimon_profile);
}
+/**
+sql:
Review Comment:
no need this comment
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/PaimonSchemaCacheValue.java:
##########
@@ -20,18 +20,42 @@
import org.apache.doris.catalog.Column;
import org.apache.doris.datasource.SchemaCacheValue;
+import org.apache.paimon.schema.TableSchema;
+import org.apache.paimon.types.DataField;
+
+import java.util.HashMap;
import java.util.List;
+import java.util.Map;
public class PaimonSchemaCacheValue extends SchemaCacheValue {
private List<Column> partitionColumns;
- public PaimonSchemaCacheValue(List<Column> schema, List<Column>
partitionColumns) {
+ private TableSchema tableSchema;
Review Comment:
Looks like we only use this `TableSchema` to build `columnIdToName`, no need
to store it.
##########
be/src/vec/exec/scan/file_scanner.cpp:
##########
@@ -1273,7 +1273,7 @@ Status FileScanner::_init_expr_ctxes() {
if (slot_info.is_file_slot) {
_file_slot_descs.emplace_back(it->second);
_file_col_names.push_back(it->second->col_name());
- if (it->second->col_unique_id() > 0) {
+ if (it->second->col_unique_id() >= 0) {
Review Comment:
Is this a bug?
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/paimon/source/PaimonScanNode.java:
##########
@@ -154,6 +155,11 @@ protected Optional<String> getSerializedTable() {
return Optional.of(serializedTable);
}
+ Map<Long, String> getSchemaInfo(Long schemaId) {
Review Comment:
```suggestion
private Map<Long, String> getSchemaInfo(Long schemaId) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
