Gabriel39 commented on code in PR #10684:
URL: https://github.com/apache/doris/pull/10684#discussion_r916410863
##########
be/src/vec/olap/olap_data_convertor.cpp:
##########
@@ -138,6 +138,7 @@ void
OlapBlockDataConvertor::OlapColumnDataConvertorBase::set_source_column(
auto nullable_column =
assert_cast<const
vectorized::ColumnNullable*>(_typed_column.column.get());
_nullmap = nullable_column->get_null_map_data().data();
+ _nullmap += row_pos;
Review Comment:
`row_pos` has been already used to compute offset of _nullmap somewhere
(HLL, BitMap, String, etc.). Maybe some basic types `row_pos` is missing to
compute `_nullmap` and we should only fix this in those types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
