yiguolei commented on code in PR #48924: URL: https://github.com/apache/doris/pull/48924#discussion_r1990526307
########## be/src/olap/page_cache.h: ########## @@ -210,9 +235,11 @@ class PageCacheHandle { } LRUCachePolicy* cache() const { return _cache; } - Slice data() const { - auto* cache_value = (DataPage*)_cache->value(_handle); - return {cache_value->data(), cache_value->size()}; + Slice data() const; + + template <typename T> + T as() const { Review Comment: 用get 不要用as, as 一般表示吧当前this 转换为某个类型 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org