morningman commented on code in PR #48752: URL: https://github.com/apache/doris/pull/48752#discussion_r1988347229
########## fe/fe-core/src/main/java/org/apache/doris/analysis/AlterUserStmt.java: ########## @@ -133,6 +135,12 @@ public void analyze(Analyzer analyzer) throws UserException { throw new AnalysisException("Only support doing one type of operation at one time"); } + if (userDesc.getUserIdent().getQualifiedUser().equals(Auth.ROOT_USER) + && !ClusterNamespace.getNameFromFullName(ConnectContext.get().getQualifiedUser()) + .equals(Auth.ROOT_USER)) { + throw new AnalysisException("Can not alter root user, except itself"); Review Comment: ```suggestion throw new AnalysisException("Only root user can modify root user"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org