wangbo commented on code in PR #48187: URL: https://github.com/apache/doris/pull/48187#discussion_r1988258062
########## fe/fe-core/src/main/java/org/apache/doris/resource/computegroup/ComputeGroupMgr.java: ########## @@ -0,0 +1,63 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.resource.computegroup; + +import org.apache.doris.cloud.system.CloudSystemInfoService; +import org.apache.doris.common.Config; +import org.apache.doris.resource.Tag; +import org.apache.doris.system.SystemInfoService; + +import com.google.common.collect.Sets; + +import java.util.Set; + +public class ComputeGroupMgr { + + private SystemInfoService systemInfoService; + + public ComputeGroupMgr(SystemInfoService systemInfoService) { + this.systemInfoService = systemInfoService; + } + + public ComputeGroup getComputeGroup(String name) { + return getComputeGroup(name, name); + } + + public ComputeGroup getComputeGroup(String id, String name) { Review Comment: 存算一体不需要id，存算分离下，大概率也不需要，因为目前cg的主要作用是拿be，正常来说上下文中传递的也都是name，不会是id，id这个接口我觉得就先移除了吧 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
