[doris] branch master updated: [Improvement] remove redundant code of VOlapScanner (#10621)

[yiguolei]

This is an automated email from the ASF dual-hosted git repository.

yiguolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git


The following commit(s) were added to refs/heads/master by this push:
     new b4c5dfc28e [Improvement] remove redundant code of VOlapScanner (#10621)
b4c5dfc28e is described below

commit b4c5dfc28ec8824b53e06d68a6cc39260a6687dc
Author: TengJianPing <18241664+jackte...@users.noreply.github.com>
AuthorDate: Wed Jul 6 17:54:10 2022 +0800

    [Improvement] remove redundant code of VOlapScanner (#10621)
---
 be/src/vec/exec/volap_scanner.cpp | 10 ----------
 be/src/vec/exec/volap_scanner.h   |  6 ------
 2 files changed, 16 deletions(-)

diff --git a/be/src/vec/exec/volap_scanner.cpp 
b/be/src/vec/exec/volap_scanner.cpp
index bd2728f988..2b3093ce8b 100644
--- a/be/src/vec/exec/volap_scanner.cpp
+++ b/be/src/vec/exec/volap_scanner.cpp
@@ -204,15 +204,6 @@ Status VOlapScanner::_init_tablet_reader_params(
         }
     }
 
-    // use _tablet_reader_params.return_columns, because reader use this to 
merge sort
-    Status res =
-            _read_row_cursor.init(_tablet->tablet_schema(), 
_tablet_reader_params.return_columns);
-    if (!res.ok()) {
-        LOG(WARNING) << "fail to init row cursor.res = " << res;
-        return Status::InternalError("failed to initialize storage read row 
cursor");
-    }
-    _read_row_cursor.allocate_memory_for_string_type(_tablet->tablet_schema());
-
     // If a agg node is this scan node direct parent
     // we will not call agg object finalize method in scan node,
     // to avoid the unnecessary SerDe and improve query performance
@@ -240,7 +231,6 @@ Status VOlapScanner::_init_return_columns(bool 
need_seq_col) {
         _return_columns.push_back(index);
         if (slot->is_nullable() && 
!_tablet->tablet_schema().column(index).is_nullable())
             _tablet_columns_convert_to_null_set.emplace(index);
-        _query_slots.push_back(slot);
     }
 
     // expand the sequence column
diff --git a/be/src/vec/exec/volap_scanner.h b/be/src/vec/exec/volap_scanner.h
index 5786a388ad..d4c40c13c1 100644
--- a/be/src/vec/exec/volap_scanner.h
+++ b/be/src/vec/exec/volap_scanner.h
@@ -89,8 +89,6 @@ public:
 
     std::vector<bool>* mutable_runtime_filter_marks() { return 
&_runtime_filter_marks; }
 
-    const std::vector<SlotDescriptor*>& get_query_slots() const { return 
_query_slots; }
-
     const std::shared_ptr<MemTracker>& mem_tracker() const { return 
_mem_tracker; }
 
 private:
@@ -129,10 +127,6 @@ private:
     std::vector<uint32_t> _return_columns;
     std::unordered_set<uint32_t> _tablet_columns_convert_to_null_set;
 
-    RowCursor _read_row_cursor;
-
-    std::vector<SlotDescriptor*> _query_slots;
-
     // time costed and row returned statistics
     int64_t _num_rows_read = 0;
     int64_t _raw_rows_read = 0;


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org