SaintBacchus opened a new pull request, #10635: URL: https://github.com/apache/doris/pull/10635
# Proposed changes Issue Number: close #10634 ## Problem Summary: There is two issue fixed in this pr: **The first issuse** is the C++ code rule of `do not call virtual function in constructor or deconstructor`. The deconstructor function of `ArrowReaderWrap` call the virtual function named `close()`. When deconstructing, it will nerver call `ParquetReaderWrap::close()` just call the `ArrowReaderWrap::close()` **The second issuse** is parallism deconstructing for `ParquetReaderWrap` and `prefetch_batch`. `prefetch_batch` use `thread.detach()` to seprate the control from `ParquetReaderWrap`, but it rely on some local vars from `ParquetReaderWrap` such as **`_closed ` /`_total_groups ` and `_reader`** In this case, `ParquetReaderWrap` may call deconstructor before `prefetch_batch` and then get the core dump. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
