gavinchou commented on code in PR #48700: URL: https://github.com/apache/doris/pull/48700#discussion_r1983075704
########## common/cpp/s3_rate_limiter.cpp: ########## @@ -91,8 +90,8 @@ std::pair<size_t, double> S3RateLimiter::_update_remain_token(long now, size_t a int64_t S3RateLimiter::add(size_t amount) { // Values obtained under lock to be checked after release - auto time = CURRENT_TIME; - auto time_nano_count = time.time_since_epoch().count(); + auto duration = std::chrono::system_clock::now().time_since_epoch(); Review Comment: should be steady_clock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org