SWJTU-ZhangLei commented on code in PR #48369: URL: https://github.com/apache/doris/pull/48369#discussion_r1982635596
########## fe/fe-core/src/main/java/org/apache/doris/catalog/HdfsStorageVault.java: ########## @@ -85,17 +90,66 @@ public HdfsStorageVault(String name, boolean ifNotExists, boolean setAsDefault) } @Override - public void modifyProperties(Map<String, String> properties) throws DdlException { - for (Map.Entry<String, String> kv : properties.entrySet()) { + public void modifyProperties(Map<String, String> newProperties) throws DdlException { + for (Map.Entry<String, String> kv : newProperties.entrySet()) { replaceIfEffectiveValue(this.properties, kv.getKey(), kv.getValue()); } + checkConnectivity(this.properties); Review Comment: The method only used in hdfsStorageVault, i don't want to take effects with other modules such as resource, maybe in the future we can move the mothod into ObjStorage.java if need -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org