starocean999 commented on code in PR #48652: URL: https://github.com/apache/doris/pull/48652#discussion_r1980604707
########## fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java: ########## @@ -5367,6 +5371,53 @@ public LogicalPlan visitRecoverDatabase(RecoverDatabaseContext ctx) { return new RecoverDatabaseCommand(dbName, dbId, newDbName); } + @Override + public LogicalPlan visitShowLoadWarnings(ShowLoadWarningsContext ctx) { + String dbName = null; + Expression wildWhere = null; + long limit = 100; + URL url = null; + + if (ctx.limitClause() != null) { + limit = Long.parseLong(ctx.limitClause().limit.getText()); + } + + if (ctx.url != null) { + String originUrl = stripQuotes(ctx.url.getText()); Review Comment: don't do complex validation in parser, you can move the code to ShowLoadWarningsCommand -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org