dataroaring commented on code in PR #48621:
URL: https://github.com/apache/doris/pull/48621#discussion_r1979233367
##########
be/src/http/action/stream_load.cpp:
##########
@@ -859,7 +859,12 @@ Status StreamLoadAction::_handle_group_commit(HttpRequest*
req,
iequal(req->header(HTTP_PARTIAL_COLUMNS), "true");
auto temp_partitions = !req->header(HTTP_TEMP_PARTITIONS).empty();
auto partitions = !req->header(HTTP_PARTITIONS).empty();
- if (!partial_columns && !partitions && !temp_partitions &&
!ctx->two_phase_commit) {
+ auto update_mode =
+ !req->header(HTTP_UNIQUE_KEY_UPDATE_MODE).empty() &&
+ (iequal(req->header(HTTP_UNIQUE_KEY_UPDATE_MODE),
"UPDATE_FIXED_COLUMNS") ||
+ iequal(req->header(HTTP_UNIQUE_KEY_UPDATE_MODE),
"UPDATE_FLEXIBLE_COLUMNS"));
+ if (!partial_columns && !partitions && !temp_partitions &&
!ctx->two_phase_commit &&
+ !update_mode) {
Review Comment:
Are there cases for update_mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
