Re: [PR] [fix](arrow) Fix UT `DataTypeSerDeArrowTest` of Date type [doris]

[via GitHub]

xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1976856890


##########
be/src/runtime/types.h:
##########
@@ -69,11 +70,11 @@ struct TypeDescriptor {
 
     // explicit TypeDescriptor(PrimitiveType type) :
     TypeDescriptor(PrimitiveType type) : type(type), len(-1), precision(-1), 
scale(-1) {
+        // TODO, should not initialize default values, force initialization by 
parameters or external.

Review Comment:
   是的，直接用 PrimitiveType 构造现在就是默认的 scale 和 precision，或许应该把 TypeDescriptor 
的构造函数变成 private，外部都要用对应类型的 create_xxx 构造，例如
   
![image](https://github.com/user-attachments/assets/b5b49af6-4cd1-48c2-92ed-d5314ccfc579)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org