zclllyybb commented on code in PR #48476:
URL: https://github.com/apache/doris/pull/48476#discussion_r1976816277
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/executable/NumericArithmetic.java:
##########
@@ -892,6 +894,17 @@ public static Expression sin(DoubleLiteral first) {
return checkOutputBoundary(new
DoubleLiteral(Math.sin(first.getValue())));
}
+ /**
+ * sinh
+ */
+ @ExecFunction(name = "sinh")
+ public static Expression sinh(DoubleLiteral first) {
+ if (inputOutOfBound(first, Double.MIN_VALUE, Double.MAX_VALUE, false,
false)) {
Review Comment:
`sin` check with bound `Double.NEGATIVE_INFINITY, Double.POSITIVE_INFINITY`.
it's meaningful and diff with `MIN_VALUE/MAX_VALUE`. please rethink your checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
