zhiqiang-hhhh commented on code in PR #48496:
URL: https://github.com/apache/doris/pull/48496#discussion_r1976383607


##########
fe/fe-core/src/main/java/org/apache/doris/common/profile/Profile.java:
##########
@@ -126,7 +128,7 @@ public Profile(boolean isEnable, int profileLevel, long 
autoProfileDurationMs) {
 
     // check if the profile file is valid and create a file input stream
     // user need to close the file stream.
-    private static FileInputStream createPorfileFileInputStream(String path) {
+    static FileInputStream createPorfileFileInputStream(String path) {

Review Comment:
   > java 里,所有的方法或者属性,都要有明确的private,public,protected 标识
   
   https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html
   
   默认的是 package private 的可见性,这里是为了方便些测试。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to