yiguolei commented on code in PR #48368:
URL: https://github.com/apache/doris/pull/48368#discussion_r1976231726
##########
be/src/service/internal_service.cpp:
##########
@@ -652,20 +654,41 @@ void
PInternalService::fetch_data(google::protobuf::RpcController* controller,
google::protobuf::Closure* done) {
// fetch_data is a light operation which will put a request rather than
wait inplace when there's no data ready.
// when there's data ready, use brpc to send. there's queue in brpc
service. won't take it too long.
- auto* cntl = static_cast<brpc::Controller*>(controller);
- auto* ctx = new GetResultBatchCtx(cntl, result, done);
- _exec_env->result_mgr()->fetch_data(request->finst_id(), ctx);
+ auto ctx = vectorized::GetResultBatchCtx::create_shared(result, done);
+ TUniqueId tid = UniqueId(request->finst_id()).to_thrift();
+ std::shared_ptr<ResultBlockBufferBase> buffer;
+ Status st = ExecEnv::GetInstance()->result_mgr()->find_buffer(tid, buffer);
+ if (!st.ok()) {
+ LOG(WARNING) << "Result buffer not found! Query ID: " << print_id(tid);
+ return;
+ }
+ vectorized::NormalResultBlockBuffer* normal_buffer =
Review Comment:
rename to MySQLResultBlockBuffer ？？？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
