yiguolei commented on code in PR #48368:
URL: https://github.com/apache/doris/pull/48368#discussion_r1974588792
##########
be/src/vec/sink/writer/vfile_result_writer.h:
##########
@@ -135,7 +136,7 @@ class VFileResultWriter final : public AsyncResultWriter {
RuntimeProfile::Counter* _written_data_bytes = nullptr;
// _sinker and _output_batch are not owned by FileResultWriter
- std::shared_ptr<BufferControlBlock> _sinker = nullptr;
+ NormalResultBlockBuffer* _sinker = nullptr;
Review Comment:
这里没有必要使用裸指针，这会增加我们的编程难度，增加core的风险
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
