Re: [PR] [fix](arrow) Fix UT `DataTypeSerDeArrowTest` of Date type [doris]

[via GitHub]

xinyiZzz commented on code in PR #48398:
URL: https://github.com/apache/doris/pull/48398#discussion_r1972743306


##########
be/src/runtime/types.h:
##########
@@ -68,15 +69,7 @@ struct TypeDescriptor {
     TypeDescriptor() : type(INVALID_TYPE), len(-1), precision(-1), scale(-1) {}
 
     // explicit TypeDescriptor(PrimitiveType type) :
-    TypeDescriptor(PrimitiveType type) : type(type), len(-1), precision(-1), 
scale(-1) {
-        if (type == TYPE_DECIMALV2) {
-            precision = 27;
-            scale = 9;

Review Comment:
   
![image](https://github.com/user-attachments/assets/831e726e-ae7c-41f9-81b0-4d38bc9be55d)
   现在 DECIMAL 的 get_type_as_type_descriptor 已经会 set precision 和 scale 了
   
   至于 TypeDescriptor 默认初始化 precision 和 scale 为 27 9，是4年前写的了，已经没用了
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org