HappenLee commented on code in PR #48314:
URL: https://github.com/apache/doris/pull/48314#discussion_r1970815056
##########
be/src/vec/aggregate_functions/aggregate_function_collect.h:
##########
@@ -346,21 +348,42 @@ struct AggregateFunctionCollectListData<void, HasLimit> {
void write(BufferWritable& buf) const {
const size_t size = column_data->size();
write_binary(size, buf);
+
+ DataTypeSerDe::FormatOptions opt;
+ auto tmp_str = ColumnString::create();
+ VectorBufferWriter tmp_buf(*tmp_str.get());
+
for (size_t i = 0; i < size; i++) {
- write_string_binary(column_data->get_data_at(i), buf);
+ tmp_str->clear();
+ tmp_str->reserve(1);
Review Comment:
why here reserve(1) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
