This is an automated email from the ASF dual-hosted git repository. dataroaring pushed a commit to branch branch-3.0 in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push: new 267935936fa branch-3.0: [fix](group commit) group commit failed if enable global enable_unique_key_partial_update #48120 (#48221) 267935936fa is described below commit 267935936fab2336317b6c8249b7823b067a1cdf Author: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> AuthorDate: Wed Feb 26 10:22:47 2025 +0800 branch-3.0: [fix](group commit) group commit failed if enable global enable_unique_key_partial_update #48120 (#48221) Cherry-picked from #48120 Co-authored-by: meiyi <me...@selectdb.com> --- be/src/runtime/group_commit_mgr.cpp | 1 + .../insert_p0/group_commit/test_group_commit_replay_wal.groovy | 4 ++-- .../insert_p0/insert_group_commit_into_unique_sync_mode.groovy | 5 +++++ 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/be/src/runtime/group_commit_mgr.cpp b/be/src/runtime/group_commit_mgr.cpp index f06f26b6418..6c8604bb51f 100644 --- a/be/src/runtime/group_commit_mgr.cpp +++ b/be/src/runtime/group_commit_mgr.cpp @@ -349,6 +349,7 @@ Status GroupCommitTable::_create_group_commit_load(int be_exe_version, request.__set_token("group_commit"); // this is a fake, fe not check it now request.__set_max_filter_ratio(1.0); request.__set_strictMode(false); + request.__set_partial_update(false); // this is an internal interface, use admin to pass the auth check request.__set_user("admin"); if (_exec_env->cluster_info()->backend_id != 0) { diff --git a/regression-test/suites/insert_p0/group_commit/test_group_commit_replay_wal.groovy b/regression-test/suites/insert_p0/group_commit/test_group_commit_replay_wal.groovy index 8ed994f74a9..2858d1e4f51 100644 --- a/regression-test/suites/insert_p0/group_commit/test_group_commit_replay_wal.groovy +++ b/regression-test/suites/insert_p0/group_commit/test_group_commit_replay_wal.groovy @@ -42,9 +42,9 @@ suite("test_group_commit_replay_wal", "nonConcurrent") { properties("replication_num" = "1", "group_commit_interval_ms"="2000") """ - sql """ set global enable_memtable_on_sink_node = true """ + sql """ set global enable_unique_key_partial_update = true """ onFinish { - sql """ set global enable_memtable_on_sink_node = false """ + sql """ set global enable_unique_key_partial_update = false """ } // 1. load success but commit rpc timeout diff --git a/regression-test/suites/insert_p0/insert_group_commit_into_unique_sync_mode.groovy b/regression-test/suites/insert_p0/insert_group_commit_into_unique_sync_mode.groovy index 0af8611922a..e8cf47ca57d 100644 --- a/regression-test/suites/insert_p0/insert_group_commit_into_unique_sync_mode.groovy +++ b/regression-test/suites/insert_p0/insert_group_commit_into_unique_sync_mode.groovy @@ -308,6 +308,11 @@ suite("insert_group_commit_into_unique_sync_mode") { // qt_sql """ select * from ${dbTableName} order by id, name, score asc; """ }; + sql """ set global enable_unique_key_partial_update = true """ + onFinish { + sql """ set global enable_unique_key_partial_update = false """ + } + // 2. stream load streamLoad { table "${tableName}" --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org