morningman commented on code in PR #48144:
URL: https://github.com/apache/doris/pull/48144#discussion_r1969434548
##########
be/src/vec/sink/writer/vfile_result_writer.cpp:
##########
@@ -271,19 +275,32 @@ Status VFileResultWriter::_send_result() {
_is_result_sent = true;
// The final stat result include:
- // FileNumber, TotalRows, FileSize and URL
- // The type of these field should be consistent with types defined
- // in OutFileClause.java of FE.
+ // | FileNumber | Int |
+ // | TotalRows | Bigint |
+ // | FileSize | Bigint |
+ // | URL | Varchar |
+ // | WriteTime | Varchar |
+ // | WriteSpeed | Varchar |
Review Comment:
```suggestion
// | WriteSpeedKB | Varchar |
```
##########
be/src/vec/sink/writer/vfile_result_writer.cpp:
##########
@@ -271,19 +275,32 @@ Status VFileResultWriter::_send_result() {
_is_result_sent = true;
// The final stat result include:
- // FileNumber, TotalRows, FileSize and URL
- // The type of these field should be consistent with types defined
- // in OutFileClause.java of FE.
+ // | FileNumber | Int |
+ // | TotalRows | Bigint |
+ // | FileSize | Bigint |
+ // | URL | Varchar |
+ // | WriteTime | Varchar |
Review Comment:
Suggest `WriteTimeSec`, so that user can know the unit clearly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
