HappenLee commented on code in PR #48247:
URL: https://github.com/apache/doris/pull/48247#discussion_r1968792793
##########
be/src/pipeline/exec/hashjoin_build_sink.cpp:
##########
@@ -571,7 +571,7 @@ Status HashJoinBuildSinkOperatorX::sink(RuntimeState*
state, vectorized::Block*
// the instance which is not build hash table, it's should wait the
signal of hash table build finished.
// but if it's running and signaled == false, maybe the source
operator have closed caused by some short circuit
// return eof will make task marked as wake_up_early
- if (!_shared_hash_table_context->signaled) {
+ if (!_shared_hash_table_context->signaled ||
state->get_task()->wake_up_early()) {
Review Comment:
Add todo to union to `wake_up_early`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
