HappenLee commented on code in PR #48166:
URL: https://github.com/apache/doris/pull/48166#discussion_r1967278524
##########
be/src/vec/columns/column_fixed_length_object.h:
##########
@@ -187,14 +187,19 @@ class ColumnFixedLengthObject final : public
COWHelper<IColumn, ColumnFixedLengt
ColumnPtr filter(const IColumn::Filter& filter, ssize_t result_size_hint)
const override {
column_match_filter_size(size(), filter.size());
auto res = create(_item_size);
- res->resize(result_size_hint);
-
- for (size_t i = 0, pos = 0; i < filter.size(); i++) {
+ size_t column_size = size();
Review Comment:
why do the change？the origin seems good？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
