pengxiangyu commented on code in PR #10280:
URL: https://github.com/apache/doris/pull/10280#discussion_r909168589


##########
be/src/agent/task_worker_pool.cpp:
##########
@@ -1683,9 +1701,64 @@ void 
TaskWorkerPool::_submit_table_compaction_worker_thread_callback() {
     }
 }
 
-void TaskWorkerPool::_storage_medium_migrate_v2_worker_thread_callback() {
+void TaskWorkerPool::_storage_refresh_storage_policy_worker_thread_callback() {

Review Comment:
   why do you delete _storage_medium_migrate_v2_worker_thread_callback?do you 
want to implement it in BE?



##########
fe/fe-core/src/main/java/org/apache/doris/analysis/ModifyTablePropertiesClause.java:
##########
@@ -91,8 +101,11 @@ public void analyze(Analyzer analyzer) throws 
AnalysisException {
             throw new AnalysisException("Alter tablet type not supported");
         } else if 
(properties.containsKey(PropertyAnalyzer.PROPERTIES_REMOTE_STORAGE_RESOURCE)) {
             throw new AnalysisException("Alter table remote_storage_resource 
is not supported.");
+        } else if 
(properties.containsKey(PropertyAnalyzer.PROPERTIES_STORAGE_POLICY)) {
+            this.needTableStable = false;
+            
setStoragePolicy(properties.getOrDefault(PropertyAnalyzer.PROPERTIES_STORAGE_POLICY,
 ""));
         } else {
-            throw new AnalysisException("Unknown table property: " + 
properties.keySet());
+                throw new AnalysisException("Unknown table property: " + 
properties.keySet());

Review Comment:
   unexpect space



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to