morningman commented on code in PR #10402:
URL: https://github.com/apache/doris/pull/10402#discussion_r909133881
##########
gensrc/thrift/PlanNodes.thrift:
##########
@@ -213,8 +215,54 @@ struct TEsScanRange {
4: required i32 shard_id
}
-struct TFileScanRange {
+struct TFileTextScanRangeParams {
+ 3: optional i8 column_separator;
+ 4: optional i8 line_delimiter;
+ // for multibytes separators
+ 5: optional i32 column_separator_length = 1;
+ 6: optional i32 line_delimiter_length = 1;
+ 7: optional string column_separator_str;
+ 8: optional string line_delimiter_str;
+}
Review Comment:
`map` is not an efficient way for serde.
And if we add more options in future, we still need to modify BE or FE code.
So I think it is ok for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
