This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new cb5b057d704 [fix](iceberg) Don't prematurely erase DeleteRows in
reading iceberg table with position delete (#47977)
cb5b057d704 is described below
commit cb5b057d7048419a984a9d1802895a3ff9ee353a
Author: Socrates <suyit...@selectdb.com>
AuthorDate: Wed Feb 19 20:55:11 2025 +0800
[fix](iceberg) Don't prematurely erase DeleteRows in reading iceberg table
with position delete (#47977)
### What problem does this PR solve?
Issue Number: close #41460
Problem Summary:
When reading the Iceberg table, previously read `DeleteRows` should not
be released immediately, as the Iceberg data file is split into multiple
`IcebergSplit`s for execution. These `IcebergSplit`s belong to the same
data file, meaning they share the same `DeleteRows`. Therefore,
`DeleteRows` in the `DeleteFile` should not be released prematurely.
Instead, they should be released when the shared_kv is reset, at which
point all `DeleteRows` will be freed along with the cached `DeleteFile`.
---
be/src/vec/exec/format/table/iceberg_reader.cpp | 6 ------
1 file changed, 6 deletions(-)
diff --git a/be/src/vec/exec/format/table/iceberg_reader.cpp
b/be/src/vec/exec/format/table/iceberg_reader.cpp
index a10358bbcbc..3d6d4df129d 100644
--- a/be/src/vec/exec/format/table/iceberg_reader.cpp
+++ b/be/src/vec/exec/format/table/iceberg_reader.cpp
@@ -302,7 +302,6 @@ Status IcebergTableReader::_position_delete_base(
const std::string data_file_path, const
std::vector<TIcebergDeleteFileDesc>& delete_files) {
std::vector<DeleteRows*> delete_rows_array;
int64_t num_delete_rows = 0;
- std::vector<DeleteFile*> erase_data;
for (const auto& delete_file : delete_files) {
SCOPED_TIMER(_iceberg_profile.delete_files_read_time);
Status create_status = Status::OK();
@@ -337,7 +336,6 @@ Status IcebergTableReader::_position_delete_base(
if (!row_ids->empty()) {
delete_rows_array.emplace_back(row_ids);
num_delete_rows += row_ids->size();
- erase_data.emplace_back(delete_file_cache);
}
};
delete_file_map.if_contains(data_file_path, get_value);
@@ -348,10 +346,6 @@ Status IcebergTableReader::_position_delete_base(
this->set_delete_rows();
COUNTER_UPDATE(_iceberg_profile.num_delete_rows, num_delete_rows);
}
- // the deleted rows are copy out, we can erase them.
- for (auto& erase_item : erase_data) {
- erase_item->erase(data_file_path);
- }
return Status::OK();
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
