dataroaring commented on code in PR #47300:
URL: https://github.com/apache/doris/pull/47300#discussion_r1959786396
##########
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java:
##########
@@ -981,14 +983,25 @@ private void checkAndPrepareMeta() {
LOG.debug("finished to restore resources. {}", this.jobId);
}
+ doCreateReplicas();
+ if (!status.ok()) {
+ return;
Review Comment:
need a case.
##########
fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java:
##########
@@ -2381,7 +2410,12 @@ private void cancelInternal(boolean isReplay) {
LOG.info("remove restored partition in table {} when
cancelled: {}",
restoreTbl.getName(), entry.second.getName());
try {
- restoreTbl.dropPartition(dbId, entry.second.getName(),
true /* force drop */);
+
restoreTbl.dropPartitionAndReserveTablet(entry.second.getName());
+ for (MaterializedIndex index :
entry.second.getMaterializedIndices(IndexExtState.ALL)) {
+ for (Tablet tablet : index.getTablets()) {
+
Env.getCurrentInvertedIndex().deleteTablet(tablet.getId());
+ }
+ }
Review Comment:
Catalog.erasePartitionDropBackendReplicas is not called now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
