csun5285 commented on code in PR #47987:
URL: https://github.com/apache/doris/pull/47987#discussion_r1959025365
##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -164,10 +164,6 @@ void
VerticalSegmentWriter::_init_column_meta(ColumnMetaPB* meta, uint32_t colum
for (uint32_t i = 0; i < column.get_subtype_count(); ++i) {
_init_column_meta(meta->add_children_columns(), column_id,
column.get_sub_column(i));
}
- // add sparse column to footer
Review Comment:
delete it in segmentwriter.cpp
##########
be/src/olap/rowset/segment_v2/hierarchical_data_reader.h:
##########
@@ -100,7 +100,8 @@ class HierarchicalDataReader : public ColumnIterator {
Status _process_nested_columns(
vectorized::ColumnObject& container_variant,
const std::map<vectorized::PathInData,
vectorized::PathsWithColumnAndType>&
- nested_subcolumns);
+ nested_subcolumns,
+ size_t nrows);
Review Comment:
delete it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
