This is an automated email from the ASF dual-hosted git repository.
panxiaolei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new ad49e68631c [chore](BE) Support SIMD interfaces in libdivide and
remove a wrong clang-tidy check (#47756)
ad49e68631c is described below
commit ad49e68631cdc342b8e39dce4b44c878ae1e9272
Author: zclllyybb <zhaochan...@selectdb.com>
AuthorDate: Tue Feb 18 10:13:11 2025 +0800
[chore](BE) Support SIMD interfaces in libdivide and remove a wrong
clang-tidy check (#47756)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
`portability-simd-intrinsics` shouldn't be checked because it suggests
an incomplete util which may be harmful to performance.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [x] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [x] Confirm the release note
- [x] Confirm test cases
- [x] Confirm document
- [x] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
.clang-tidy | 1 -
be/CMakeLists.txt | 5 +++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/.clang-tidy b/.clang-tidy
index 1f77a9e3164..ce5600d254b 100644
--- a/.clang-tidy
+++ b/.clang-tidy
@@ -25,7 +25,6 @@ Checks: |
-readability-named-parameter,
-readability-avoid-const-params-in-decls,
-readability-convert-member-functions-to-static,
- portability-simd-intrinsics,
performance-type-promotion-in-math-fn,
performance-faster-string-find,
performance-inefficient-algorithm,
diff --git a/be/CMakeLists.txt b/be/CMakeLists.txt
index e40b0f64089..18e7793f714 100644
--- a/be/CMakeLists.txt
+++ b/be/CMakeLists.txt
@@ -92,6 +92,7 @@ message(STATUS "USE_MEM_TRACKER is ${USE_MEM_TRACKER}")
message(STATUS "USE_JEMALLOC is ${USE_JEMALLOC}")
message(STATUS "USE_UNWIND is ${USE_UNWIND}")
message(STATUS "ENABLE_PCH is ${ENABLE_PCH}")
+message(STATUS "USE_AVX2 is ${USE_AVX2}")
# set CMAKE_BUILD_TYPE
if (NOT CMAKE_BUILD_TYPE)
@@ -356,13 +357,17 @@ endif()
# simd for architectures
if ("${CMAKE_BUILD_TARGET_ARCH}" STREQUAL "x86" OR
"${CMAKE_BUILD_TARGET_ARCH}" STREQUAL "x86_64")
add_compile_options(-msse4.2)
+ add_definitions(-DLIBDIVIDE_SSE2)
if (USE_AVX2)
add_compile_options(-mavx2)
+ add_definitions(-DUSE_AVX2)
+ add_definitions(-DLIBDIVIDE_AVX2)
endif()
endif()
if (ARCH_ARM)
add_compile_options(-march=armv8-a+crc)
+ add_definitions(-DLIBDIVIDE_NEON)
endif()
#
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
