HappenLee commented on code in PR #10283:
URL: https://github.com/apache/doris/pull/10283#discussion_r906965269
##########
be/src/vec/exec/join/vhash_join_node.cpp:
##########
@@ -509,11 +517,6 @@ struct ProcessHashTableProbe {
}
output_block->get_by_position(result_column_id).column =
std::move(new_filter_column);
- } else if constexpr (JoinOpType::value ==
TJoinOp::RIGHT_OUTER_JOIN) {
Review Comment:
why delete this code?
##########
be/src/vec/functions/function_json.cpp:
##########
@@ -407,18 +407,36 @@ struct JsonParser<'3'> {
}
};
+template <>
+struct JsonParser<'4'> {
+ // time
+ static void update_value(StringParser::ParseResult& result,
rapidjson::Value& value,
+ StringRef data,
rapidjson::Document::AllocatorType& allocator) {
+ value.SetString(data.data + 1, data.size - 2, allocator);
Review Comment:
some comment? what means `data + 1` and `size - 2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
