dataroaring commented on code in PR #47300:
URL: https://github.com/apache/doris/pull/47300#discussion_r1956193363


##########
fe/fe-core/src/main/java/org/apache/doris/catalog/PartitionInfo.java:
##########
@@ -465,13 +465,15 @@ public void readFields(DataInput in) throws IOException {
             }
 
             idToInMemory.put(partitionId, in.readBoolean());
-            if (Config.isCloudMode()) {
-                // HACK: the origin implementation of the cloud mode has code 
likes:
-                //
-                //     idToPersistent.put(partitionId, in.readBoolean());
-                //
-                // keep the compatibility here.
-                in.readBoolean();
+            if (Env.getCurrentEnvJournalVersion() > FeMetaVersion.VERSION_129) 
{
+                if (Config.isCloudMode()) {
+                    // HACK: the origin implementation of the cloud mode has 
code likes:
+                    //
+                    //     idToPersistent.put(partitionId, in.readBoolean());
+                    //
+                    // keep the compatibility here.
+                    in.readBoolean();
+                }

Review Comment:
   I am confused by code above.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to