starocean999 commented on code in PR #47894: URL: https://github.com/apache/doris/pull/47894#discussion_r1955504415
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/DescribeCommand.java: ########## @@ -0,0 +1,386 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.plans.commands; + +import org.apache.doris.analysis.Expr; +import org.apache.doris.analysis.PartitionNames; +import org.apache.doris.analysis.TableName; +import org.apache.doris.analysis.TableValuedFunctionRef; +import org.apache.doris.catalog.Column; +import org.apache.doris.catalog.DatabaseIf; +import org.apache.doris.catalog.Env; +import org.apache.doris.catalog.JdbcTable; +import org.apache.doris.catalog.MaterializedIndexMeta; +import org.apache.doris.catalog.MysqlTable; +import org.apache.doris.catalog.OdbcTable; +import org.apache.doris.catalog.OlapTable; +import org.apache.doris.catalog.ScalarType; +import org.apache.doris.catalog.TableIf; +import org.apache.doris.common.AnalysisException; +import org.apache.doris.common.ErrorCode; +import org.apache.doris.common.ErrorReport; +import org.apache.doris.common.FeConstants; +import org.apache.doris.common.Pair; +import org.apache.doris.common.proc.IndexSchemaProcNode; +import org.apache.doris.common.proc.ProcNodeInterface; +import org.apache.doris.common.proc.ProcService; +import org.apache.doris.common.proc.TableProcDir; +import org.apache.doris.common.util.Util; +import org.apache.doris.datasource.CatalogIf; +import org.apache.doris.mysql.privilege.PrivPredicate; +import org.apache.doris.nereids.trees.plans.PlanType; +import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor; +import org.apache.doris.qe.ConnectContext; +import org.apache.doris.qe.ShowResultSet; +import org.apache.doris.qe.ShowResultSetMetaData; +import org.apache.doris.qe.StmtExecutor; + +import com.google.common.base.Strings; +import com.google.common.collect.Lists; +import org.apache.commons.lang3.StringUtils; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +/** + * Describe command, support + * describe tbl + * describe tbl all + * describe tbl partition p1 + * describe tbl partition (p1, p2) + * describe function tvf + */ +public class DescribeCommand extends Command implements ForwardWithSync { + private static final Logger LOG = LogManager.getLogger(DescribeCommand.class); + + private String tableName; + private boolean isAllTables = false; + private boolean isOlapTable = false; + + private PartitionNames partitionNames; + + private TableValuedFunctionRef tableValuedFunctionRef; + private boolean isTableValuedFunction; + + private List<List<String>> rows = new LinkedList<List<String>>(); + private ProcNodeInterface node; + + public DescribeCommand(String tableName, boolean isAllTables) { + super(PlanType.DESCRIBE); + this.tableName = tableName; + this.isAllTables = isAllTables; + } + + public DescribeCommand(String tableName, boolean isAllTables, PartitionNames partitionNames) { + super(PlanType.DESCRIBE); + this.tableName = tableName; + this.isAllTables = isAllTables; + this.partitionNames = partitionNames; + } + + public DescribeCommand(TableValuedFunctionRef tableValuedFunctionRef) { + super(PlanType.DESCRIBE); + this.tableValuedFunctionRef = tableValuedFunctionRef; + this.isTableValuedFunction = true; + this.isAllTables = false; + } + + /** + * getAllMetaData + */ + private ShowResultSetMetaData getAllMetaData() { + ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder(); + builder.addColumn(new Column("IndexName", ScalarType.createVarchar(20))); + builder.addColumn(new Column("IndexKeysType", ScalarType.createVarchar(20))); + builder.addColumn(new Column("Field", ScalarType.createVarchar(20))); + builder.addColumn(new Column("Type", ScalarType.createVarchar(20))); + builder.addColumn(new Column("InternalType", ScalarType.createVarchar(20))); + builder.addColumn(new Column("Null", ScalarType.createVarchar(10))); + builder.addColumn(new Column("Key", ScalarType.createVarchar(10))); + builder.addColumn(new Column("Default", ScalarType.createVarchar(30))); + builder.addColumn(new Column("Extra", ScalarType.createVarchar(30))); + builder.addColumn(new Column("Visible", ScalarType.createVarchar(10))); + builder.addColumn(new Column("DefineExpr", ScalarType.createVarchar(30))); + builder.addColumn(new Column("WhereClause", ScalarType.createVarchar(30))); + return builder.build(); + } + + /** + * getMysqlMetaData + */ + private ShowResultSetMetaData getMysqlMetaData() { + ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder(); + builder.addColumn(new Column("Host", ScalarType.createVarchar(30))); + builder.addColumn(new Column("Port", ScalarType.createVarchar(10))); + builder.addColumn(new Column("User", ScalarType.createVarchar(30))); + builder.addColumn(new Column("Password", ScalarType.createVarchar(30))); + builder.addColumn(new Column("Database", ScalarType.createVarchar(30))); + builder.addColumn(new Column("Table", ScalarType.createVarchar(30))); + return builder.build(); + } + + /** + * getMetaData + */ + public ShowResultSetMetaData getMetaData() { + if (!isAllTables) { + ShowResultSetMetaData.Builder builder = ShowResultSetMetaData.builder(); + for (String col : IndexSchemaProcNode.TITLE_NAMES) { + builder.addColumn(new Column(col, ScalarType.createVarchar(30))); + } + return builder.build(); + } else { + if (isOlapTable) { + return getAllMetaData(); + } else { + return getMysqlMetaData(); + } + } + } + + @Override + public void run(ConnectContext ctx, StmtExecutor executor) throws Exception { Review Comment: please follow DescribeStmt's logic, and do some minor changes is better to review. And implement doRun method like ``` @Override public ShowResultSet doRun(ConnectContext ctx, StmtExecutor executor) throws Exception { List<List<String>> rows = xxxxx; return new ShowResultSet(META_DATA, rows); } ``` before return result, you need do exact the same thing like DescribeStmt.analyze(Analyzer analyzer) method, but remove dependency of old Analyzer. So you can create a new method private void validate(ConnectContext ctx) throws AnalysisException { ...} and put all DescribeStmt.analyze stuff in it. And you might add a new function in TableValuedFunctionRef like bellow: ``` public void validate(ConnectContext ctx) throws AnalysisException { // check privilige for backends/local tvf if (funcName.equalsIgnoreCase(BackendsTableValuedFunction.NAME) || funcName.equalsIgnoreCase(LocalTableValuedFunction.NAME)) { if (!Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ctx, PrivPredicate.ADMIN) && !Env.getCurrentEnv().getAccessManager().checkGlobalPriv(ctx, PrivPredicate.OPERATOR)) { ErrorReport.reportAnalysisException(ErrorCode.ERR_SPECIFIC_ACCESS_DENIED_ERROR, "ADMIN/OPERATOR"); } } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
