zclllyybb commented on code in PR #45926:
URL: https://github.com/apache/doris/pull/45926#discussion_r1954877093


##########
fe/fe-core/src/main/java/org/apache/doris/rpc/BackendServiceProxy.java:
##########
@@ -569,4 +569,14 @@ public Future<InternalService.PGetBeResourceResponse> 
getBeResourceAsync(TNetwor
         return null;
     }
 
+    public Future<InternalService.PDeleteDictionaryResponse> 
deleteDictionaryAsync(TNetworkAddress address,
+            int timeoutSec, InternalService.PDeleteDictionaryRequest request) {
+        try {
+            final BackendServiceClient client = getProxy(address);

Review Comment:
   just a warning. because we rely on information collecting and drop 
dictionaries every time when we meet invalid dictionary from BE. so any 
deletion failure does not matter - it will be dropped at last.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to