This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 89860fd0e3 [opt] delete the redundant parameter of
_execute_non_nullable (#10173)
89860fd0e3 is described below
commit 89860fd0e326a16607940f4b4967aa34f2678127
Author: carlvinhust2012 <huchengha...@126.com>
AuthorDate: Fri Jun 24 19:22:50 2022 +0800
[opt] delete the redundant parameter of _execute_non_nullable (#10173)
1. This pr is used to delete the redundant parameter of
_execute_non_nullable.
2. This modification will not affect the function "element_at".
---
be/src/vec/functions/array/function_array_element.h | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/be/src/vec/functions/array/function_array_element.h
b/be/src/vec/functions/array/function_array_element.h
index a37913915b..315ce5cb2a 100644
--- a/be/src/vec/functions/array/function_array_element.h
+++ b/be/src/vec/functions/array/function_array_element.h
@@ -69,11 +69,7 @@ public:
args = {col_left, block.get_by_position(arguments[1])};
}
- auto result_type = remove_nullable(
-
check_and_get_data_type<DataTypeArray>(args[0].type.get())->get_nested_type());
-
- auto res_column = _execute_non_nullable(args, result_type,
input_rows_count, src_null_map,
- dst_null_map);
+ auto res_column = _execute_non_nullable(args, input_rows_count,
src_null_map, dst_null_map);
if (!res_column) {
return Status::RuntimeError(
fmt::format("unsupported types for function {}({}, {})",
get_name(),
@@ -182,8 +178,8 @@ private:
}
ColumnPtr _execute_non_nullable(const ColumnsWithTypeAndName& arguments,
- const DataTypePtr& result_type, size_t
input_rows_count,
- const UInt8* src_null_map, UInt8*
dst_null_map) {
+ size_t input_rows_count, const UInt8*
src_null_map,
+ UInt8* dst_null_map) {
// check array nested column type and get data
auto left_column =
arguments[0].column->convert_to_full_column_if_const();
const auto& array_column = reinterpret_cast<const
ColumnArray&>(*left_column);
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
