morrySnow commented on code in PR #2031: URL: https://github.com/apache/doris-website/pull/2031#discussion_r1951961571
########## docs/sql-manual/sql-statements/data-governance/ALTER-SQL_BLOCK_RULE.md: ########## @@ -25,41 +25,46 @@ under the License. --> - ## Description -Modify SQL blocking rules to allow modification of each item such as sql/sqlHash/partition_num/tablet_num/cardinality/global/enable. +This statement is used to modify an SQL block rule. + +## Syntax -grammar: ```sql -ALTER SQL_BLOCK_RULE rule_name -[PROPERTIES ("key"="value", ...)]; +ALTER SQL_BLOCK_RULE <rule_name> +PROPERTIES ( + -- property + <property> + -- Additional properties + [ , ... ] + ) ``` -illustrate: +## Required Parameters -- sql and sqlHash cannot be set at the same time. This means that if a rule sets sql or sqlHash, the other attribute cannot be modified; -- sql/sqlHash and partition_num/tablet_num/cardinality cannot be set at the same time. For example, if a rule sets partition_num, then sql or sqlHash cannot be modified; +**<rule_name>** -## Example +> The name of the rule. -1. Modify according to SQL properties +**<property>** -```sql -ALTER SQL_BLOCK_RULE test_rule PROPERTIES("sql"="select \\* from test_table","enable"="true") -``` +See the introduction of [CREATE SQL_BLOCK_RULE](../data-governance/CREATE-SQL_BLOCK_RULE.md) for details. -2. If a rule sets partition_num, then sql or sqlHash cannot be modified +## Permissions Review Comment: ```suggestion ## Access Control Requirements ``` ########## docs/sql-manual/sql-statements/data-governance/ALTER-SQL_BLOCK_RULE.md: ########## @@ -25,41 +25,46 @@ under the License. --> - ## Description -Modify SQL blocking rules to allow modification of each item such as sql/sqlHash/partition_num/tablet_num/cardinality/global/enable. +This statement is used to modify an SQL block rule. + +## Syntax -grammar: ```sql -ALTER SQL_BLOCK_RULE rule_name -[PROPERTIES ("key"="value", ...)]; +ALTER SQL_BLOCK_RULE <rule_name> +PROPERTIES ( + -- property + <property> + -- Additional properties + [ , ... ] + ) ``` -illustrate: +## Required Parameters -- sql and sqlHash cannot be set at the same time. This means that if a rule sets sql or sqlHash, the other attribute cannot be modified; -- sql/sqlHash and partition_num/tablet_num/cardinality cannot be set at the same time. For example, if a rule sets partition_num, then sql or sqlHash cannot be modified; +**<rule_name>** -## Example +> The name of the rule. -1. Modify according to SQL properties +**<property>** Review Comment: ```suggestion **1. `<property>`** ``` ########## docs/sql-manual/sql-statements/data-governance/ALTER-SQL_BLOCK_RULE.md: ########## @@ -25,41 +25,46 @@ under the License. --> - ## Description -Modify SQL blocking rules to allow modification of each item such as sql/sqlHash/partition_num/tablet_num/cardinality/global/enable. +This statement is used to modify an SQL block rule. + +## Syntax -grammar: ```sql -ALTER SQL_BLOCK_RULE rule_name -[PROPERTIES ("key"="value", ...)]; +ALTER SQL_BLOCK_RULE <rule_name> +PROPERTIES ( + -- property + <property> + -- Additional properties + [ , ... ] + ) ``` -illustrate: +## Required Parameters -- sql and sqlHash cannot be set at the same time. This means that if a rule sets sql or sqlHash, the other attribute cannot be modified; -- sql/sqlHash and partition_num/tablet_num/cardinality cannot be set at the same time. For example, if a rule sets partition_num, then sql or sqlHash cannot be modified; +**<rule_name>** Review Comment: ```suggestion **1. `<rule_name>`** ``` ########## docs/sql-manual/sql-statements/data-governance/ALTER-SQL_BLOCK_RULE.md: ########## @@ -25,41 +25,46 @@ under the License. --> - ## Description -Modify SQL blocking rules to allow modification of each item such as sql/sqlHash/partition_num/tablet_num/cardinality/global/enable. +This statement is used to modify an SQL block rule. + +## Syntax -grammar: ```sql -ALTER SQL_BLOCK_RULE rule_name -[PROPERTIES ("key"="value", ...)]; +ALTER SQL_BLOCK_RULE <rule_name> +PROPERTIES ( + -- property + <property> + -- Additional properties + [ , ... ] + ) ``` -illustrate: +## Required Parameters -- sql and sqlHash cannot be set at the same time. This means that if a rule sets sql or sqlHash, the other attribute cannot be modified; -- sql/sqlHash and partition_num/tablet_num/cardinality cannot be set at the same time. For example, if a rule sets partition_num, then sql or sqlHash cannot be modified; +**<rule_name>** -## Example +> The name of the rule. -1. Modify according to SQL properties +**<property>** -```sql -ALTER SQL_BLOCK_RULE test_rule PROPERTIES("sql"="select \\* from test_table","enable"="true") -``` +See the introduction of [CREATE SQL_BLOCK_RULE](../data-governance/CREATE-SQL_BLOCK_RULE.md) for details. -2. If a rule sets partition_num, then sql or sqlHash cannot be modified +## Permissions -```sql -ALTER SQL_BLOCK_RULE test_rule2 PROPERTIES("partition_num" = "10","tablet_num"="300","enable"="true") -``` +The user executing this SQL command must have at least the following permissions: -## Keywords +| Permission | Object | Description | Review Comment: ```suggestion | Privilege | Object | Notes | ``` ########## docs/sql-manual/sql-statements/data-governance/ALTER-SQL_BLOCK_RULE.md: ########## @@ -25,41 +25,46 @@ under the License. --> - ## Description -Modify SQL blocking rules to allow modification of each item such as sql/sqlHash/partition_num/tablet_num/cardinality/global/enable. +This statement is used to modify an SQL block rule. + +## Syntax -grammar: ```sql -ALTER SQL_BLOCK_RULE rule_name -[PROPERTIES ("key"="value", ...)]; +ALTER SQL_BLOCK_RULE <rule_name> +PROPERTIES ( + -- property + <property> + -- Additional properties + [ , ... ] + ) ``` -illustrate: +## Required Parameters -- sql and sqlHash cannot be set at the same time. This means that if a rule sets sql or sqlHash, the other attribute cannot be modified; -- sql/sqlHash and partition_num/tablet_num/cardinality cannot be set at the same time. For example, if a rule sets partition_num, then sql or sqlHash cannot be modified; +**<rule_name>** -## Example +> The name of the rule. -1. Modify according to SQL properties +**<property>** -```sql -ALTER SQL_BLOCK_RULE test_rule PROPERTIES("sql"="select \\* from test_table","enable"="true") -``` +See the introduction of [CREATE SQL_BLOCK_RULE](../data-governance/CREATE-SQL_BLOCK_RULE.md) for details. -2. If a rule sets partition_num, then sql or sqlHash cannot be modified +## Permissions -```sql -ALTER SQL_BLOCK_RULE test_rule2 PROPERTIES("partition_num" = "10","tablet_num"="300","enable"="true") -``` +The user executing this SQL command must have at least the following permissions: -## Keywords +| Permission | Object | Description | +| ------------ | ------ | ----------- | +| *ADMIN_PRIV* | Global | | Review Comment: ```suggestion | ADMIN_PRIV | Global | | ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org