zhannngchen commented on code in PR #47766:
URL: https://github.com/apache/doris/pull/47766#discussion_r1950859777
##########
be/src/cloud/cloud_meta_mgr.cpp:
##########
@@ -1201,23 +1201,24 @@ Status
CloudMetaMgr::get_delete_bitmap_update_lock(const CloudTablet& tablet, in
return st;
}
-Status CloudMetaMgr::remove_delete_bitmap_update_lock(const CloudTablet&
tablet, int64_t lock_id,
- int64_t initiator) {
- VLOG_DEBUG << "remove_delete_bitmap_update_lock , tablet_id: " <<
tablet.tablet_id()
- << ",lock_id:" << lock_id;
+void CloudMetaMgr::remove_delete_bitmap_update_lock(int64_t table_id, int64_t
lock_id,
+ int64_t initiator, int64_t
tablet_id) {
+ LOG(INFO) << "remove_delete_bitmap_update_lock ,table_id: " << table_id
+ << ",lock_id:" << lock_id << ",initiator:" << initiator <<
",tablet_id:" << tablet_id;
RemoveDeleteBitmapUpdateLockRequest req;
RemoveDeleteBitmapUpdateLockResponse res;
req.set_cloud_unique_id(config::cloud_unique_id);
- req.set_tablet_id(tablet.tablet_id());
+ req.set_table_id(table_id);
+ req.set_tablet_id(tablet_id);
req.set_lock_id(lock_id);
req.set_initiator(initiator);
auto st = retry_rpc("remove delete bitmap update lock", req, &res,
&MetaService_Stub::remove_delete_bitmap_update_lock);
if (!st.ok()) {
- LOG(WARNING) << "remove delete bitmap update lock fail,tablet_id=" <<
tablet.tablet_id()
- << " lock_id=" << lock_id << " st=" << st.to_string();
+ LOG(WARNING) << "remove delete bitmap update lock fail,table_id=" <<
table_id
+ << ",tablet_id=" << tablet_id << ",lock_id=" << lock_id
+ << ",st=" << st.to_string();
}
- return st;
Review Comment:
Why not return the status?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
